Skip to content

ITSMFT: share tracking slab allocation primitives - #15730

Open
mpuccio wants to merge 7 commits into
AliceO2Group:devfrom
mpuccio:itsmft-tracking-precursor
Open

ITSMFT: share tracking slab allocation primitives#15730
mpuccio wants to merge 7 commits into
AliceO2Group:devfrom
mpuccio:itsmft-tracking-precursor

Conversation

@mpuccio

@mpuccio mpuccio commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@mpuccio
mpuccio requested a review from davidrohr as a code owner August 27, 2026 21:21
@alibuild

alibuild commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 9f24e0b at 2026-08-28 02:26:

## sw/BUILD/QualityControl-latest/log
/sw/SOURCES/QualityControl/v1.195.1/v1.195.1/Modules/ITS/src/ITSTrackTask.cxx:28:10: fatal error: ITStracking/Constants.h: No such file or directory
ninja: build stopped: cannot make progress due to previous errors.

Full log here.

f3sch
f3sch requested changes Aug 28, 2026
View reviewed changes

@f3sch f3sch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is mostly noise from bounded_vector to o2::itsmft::tracking::bounded_vector where a using decl. would have sufficed. This is fine I guess. See some comments below.
Changed the header include in AliceO2Group/QualityControl#2687

Comment thread Detectors/ITSMFT/common/tracking/src/BoundedAllocator.cxx Outdated
Comment thread Detectors/ITSMFT/common/tracking/include/ITSMFTTracking/CapacityEstimator.h Outdated
Comment thread Detectors/ITSMFT/common/tracking/src/CapacityEstimator.cxx Outdated
Comment thread Detectors/ITSMFT/ITS/tracking/test/CMakeLists.txt Outdated
Comment thread Detectors/ITSMFT/common/tracking/include/ITSMFTTracking/SlabBumpAllocator.h Outdated
@alibuild

alibuild commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 3df7d03 at 2026-08-28 15:52:

## sw/BUILD/QualityControl-latest/log
/sw/SOURCES/QualityControl/v1.195.2/v1.195.2/Modules/ITS/src/ITSTrackTask.cxx:28:10: fatal error: ITStracking/Constants.h: No such file or directory
ninja: build stopped: cannot make progress due to previous errors.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@f3sch f3sch f3sch approved these changes
@fprino fprino Awaiting requested review from fprino fprino is a code owner
@mcoquet642 mcoquet642 Awaiting requested review from mcoquet642 mcoquet642 is a code owner
@mconcas mconcas Awaiting requested review from mconcas mconcas is a code owner
@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner
@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner
@arossi81 arossi81 Awaiting requested review from arossi81 arossi81 is a code owner
@njacazio njacazio Awaiting requested review from njacazio njacazio is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@davidrohr davidrohr Awaiting requested review from davidrohr davidrohr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mpuccio @alibuild @f3sch